Attention is currently required from: Kapil Porwal, Sridhar Siricilla, Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74995?usp=email )
Change subject: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS ......................................................................
Patch Set 37:
(8 comments)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/74995/comment/381642a1_67592e3d : PS36, Line 48: SOC_INTEL_PARTITION_FW_CMOS_OFFSET
SOC_INTEL_CSE_FW_PARTITION_CMOS_OFFSET ?
Acknowledged
https://review.coreboot.org/c/coreboot/+/74995/comment/674d2719_f6d6e7fd : PS36, Line 53: firmware partition
may be worth clarifying that its the CSE FW partition
Acknowledged
File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74995/comment/fbe49d59_c1a2f146 : PS36, Line 12:
i don't think any other changes are necessary here apart from adding cse_lite_cmos. […]
Acknowledged
File src/soc/intel/common/block/cse/cse_lite_cmos.c:
https://review.coreboot.org/c/coreboot/+/74995/comment/64ee2c9a_bfff7970 : PS36, Line 8: 0x46575054
it has to be opposite as little endian
Acknowledged
https://review.coreboot.org/c/coreboot/+/74995/comment/2fd36985_01105174 : PS36, Line 100: get_cmos_cse_version
get_cmos_cse_rw_fw_version
Acknowledged
https://review.coreboot.org/c/coreboot/+/74995/comment/f0447904_4f6305d3 : PS36, Line 114: set_cmos_cse_version
same
Acknowledged
https://review.coreboot.org/c/coreboot/+/74995/comment/ec984536_e3e92c78 : PS36, Line 134: printk(BIOS_WARNING, "CMOS fw version corrupted, initiating memory re-init\n");
we don't need this IMO
Acknowledged
https://review.coreboot.org/c/coreboot/+/74995/comment/35804b93_c6713810 : PS36, Line 146: printk(BIOS_WARNING, "CMOS fw version corrupted, initiating memory re-init\n");
we don't need this
Acknowledged