shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48638 )
Change subject: mb/google/poppy/variants/nautilus: Use separate camera_pmic.asl ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48638/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48638/1//COMMIT_MSG@10 PS1, Line 10: found the CL:1947743 has impact on it.
Ricardo found an issue in the camera ACPI code and pushed a CL here: https://review.coreboot. […]
We'll check with that CL.
https://review.coreboot.org/c/coreboot/+/48638/1//COMMIT_MSG@11 PS1, Line 11: Nautilus series uses different camera module with baseboard, so : changing power sequence of camera is not good for nautilus.
It is not clear to me why the code for soraka worked for Nautilus before, but not after the change y […]
BTW Nautilus has only one camera module, power sequence code for CAM1 would not be called. As following our test result in b:174941580, CL:1947743 has impact the camera proving issue and it changed the power on sequence for CAM0. I just thought the change was based on the camera module's spec (or any reference) for baseboard and it might cause the issue on nautilus which uses other camera module than baseboard.