Attention is currently required from: Tim Wawrzynczak, Christian Walter.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61718 )
Change subject: drivers/i2c/tpm/cr50: Remove unused `chip` function arguments
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/61718/comment/c119029d_3a118d08
PS2, Line 62: static int
out of topic:
I'd use "static enum cb_err " ...
return CB_ERR or CB_SUCCESS
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61718
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8d32fdf340c8ef49fefd11da433e3b6ee561f29
Gerrit-Change-Number: 61718
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 10:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment