9 Oct
2019
9 Oct
'19
11:48 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35471 )
Change subject: soc/mediatek/mt8183: Refactor DRAM init by bit fields API ......................................................................
Patch Set 14: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35471/14/src/soc/mediatek/mt8183/dr... PS14, Line 532: t2_1 >> 24 nit: Wouldn't it be much better to just change TEST2_1_CAL and friends to not already be shifted in the first place?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I327297dd10718fbef7275fe95c95d00d3ab6ac84
Gerrit-Change-Number: 35471
Gerrit-PatchSet: 14
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Assignee: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Oct 2019 23:48:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment