Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42687 )
Change subject: soc/amd/common: Refactor GPIO SCI/SMI interrupts
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42687/4/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42687/4/src/soc/amd/common/block/gp...
PS4, Line 73: regs->polarity &= ~mask;
It'd be helpful to add comments to handling of LEVEL vs EDGE stanzas here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c7cd70ab38d0d8e745b0a611b780d2b0b8dc5b
Gerrit-Change-Number: 42687
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 05:46:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment