Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 7:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45159/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/7//COMMIT_MSG@16 PS7, Line 16: https://chromium-review.googlesource.com : 2403386 : 2403387 : 2403385 : 2403384 : 2403383 : 2403382 : 2403381 : 2403380 suggestion: a link to just the first patch is fine, just say here's the beginning of the patchset supports this
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 149: Name (REFC, 0) Would you mind adding a comment here explaining what `REFC` is for?
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 168: If ((REFC == 0)) `If (REFC == 0)`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 175: REFC = REFC + 1 nit: ASL 2.0 supports `REFC++`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 206: REFC = REFC - 1 nit: ASL 2.0 supports `REFC--`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 352: If ((REFC == 0)) `If (REFC == 0)`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 357: REFC = REFC + 1 nit: `REFC++`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 362: If ((REFC == 1)) `If (REFC == 1)`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 367: REFC = REFC - 1 nit: `REFC--`