Attention is currently required from: Arthur Heymans, Julius Werner, Subrata Banik.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81964?usp=email )
Change subject: util/cbfstool: Add --64 option for 64-bit payload stitching
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:
https://review.coreboot.org/c/coreboot/+/81964/comment/27c4c4f1_230b1684 :
PS2, Line 144: /* 1 for 64-bit payload. 0 for 32-bit payload. */
: uint32_t payload_64_bit;
payload_64_bit is used as boot in util/cbfstool/cbfstool.c file.
Please why payload_64_bit is declared as uint32_t here ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81964?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41562041d6c09869c7966ea31503f002ca1caefa
Gerrit-Change-Number: 81964
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 19 Apr 2024 09:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment