Attention is currently required from: Jeremy Soller, Tim Wawrzynczak, Patrick Rudolph.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56900 )
Change subject: soc/intel/common: Add TGL-H PCI IDs
......................................................................
Patch Set 2:
(1 comment)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/56900/comment/a8395228_0c491602
PS1, Line 3942: #define PCI_DEVICE_ID_INTEL_TGL_ID_H_4_1 0x9A16
Where did this one go?
The value doesn't exist in the CPU EDS. What I was originally looking at when I added this was TGL H35 (0x9a14/0x9a1a), but I'm not sure how those should be added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I751d0d59aff9e93e2aa92546db78775bd1e6ef22
Gerrit-Change-Number: 56900
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 16 Aug 2021 18:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment