Attention is currently required from: Anand Vaikar, Felix Held, Jason Glenesk, Matt DeVillier, ritul guru.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74069?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/amd/mayan: Enable the DT and M.2 SSD1 PCIE slots
......................................................................
Patch Set 16:
(1 comment)
File src/mainboard/amd/mayan/Kconfig:
https://review.coreboot.org/c/coreboot/+/74069/comment/94ccf30c_556a0fcc :
PS16, Line 83: choice
: prompt "DT SLOT/M.2 SSD1 ENABLE"
: default ENABLE_DT_SLOT_MAYAN
: help
: Either DT slot or M.2 SSD1 can be used to boot on Mayan,
: as they are sharing IO lanes.
:
: config ENABLE_DT_SLOT_MAYAN
: bool "Enable DT slot"
:
: config ENABLE_M2_SSD1_MAYAN
: bool "Enable M.2 SSD1"
:
: config DISABLE_DT_M2_MAYAN
: bool "Disable both DT and M.2 slot"
:
: endchoice
Please align with `src/mainboard/amd/birman/Kconfig` or move it to common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74069?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id141e5e55ef6e25722b411975a59c9764b86f624
Gerrit-Change-Number: 74069
Gerrit-PatchSet: 16
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 11 Jun 2023 20:21:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment