Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte...
PS15, Line 8: /* Leave eSPI pins untouched from default settings */
Can delete this.
https://review.coreboot.org/c/coreboot/+/42301/15/src/mainboard/google/volte...
PS15, Line 10: /* A0 thru A6 come configured out of reset, do not touch */
: /* A0 : ESPI_IO0 ==> ESPI_IO_0 */
: /* A1 : ESPI_IO1 ==> ESPI_IO_1 */
: /* A2 : ESPI_IO2 ==> ESPI_IO_2 */
: /* A3 : ESPI_IO3 ==> ESPI_IO_3 */
: /* A4 : ESPI_CS# ==> ESPI_CS_L */
: /* A5 : ESPI_CLK ==> ESPI_CLK */
: /* A6 : ESPI_RESET# ==> NC(TP764) */
:
Please delete these.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 15
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Jul 2020 15:54:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment