Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60447 )
Change subject: mb/google/corsola: Initialize krabby display ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/60447/comment/4c96f95f_4a1d0beb PS5, Line 97: NULL what about putting a place holder function? then we don't need to check NULL pointers.
https://review.coreboot.org/c/coreboot/+/60447/comment/8ce140f6_d05b3825 PS5, Line 124: if (bridge->get_edid) { : if (bridge->get_edid(i2c_bus, &edid) < 0) { I'd rather always provide the implementation and do:
assert(bridge->get_edid); if (bridge->get_edid(...))