Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41712 )
Change subject: soc/intel/common: Add restore and enable GPIO PM
......................................................................
Patch Set 2:
Patch Set 2:
I nailed the GPIO communities mapping. Please provide ideas if any.. I verified at my Deltan.
Instead can you check with below changes + patch set 1(is deltan not using MS0x?) on TGL?
I checked below on JSL and verified it working.
https://review.coreboot.org/c/coreboot/+/41721
- Case (0) {
+ Case (COMM_0) {
Local0 = PID_GPIOCOM0
}
- Case (1) {
+ Case (COMM_1) {
Local0 = PID_GPIOCOM1
}
- Case (2) {
+ Case (COMM_2) {
Local0 = PID_GPIOCOM2
}
- Case (4) {
+ Case (COMM_4) {
Local0 = PID_GPIOCOM4
}
- Case (5) {
+ Case (COMM_5) {
Local0 = PID_GPIOCOM5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5e4553d568a872de234a2d671118acbae0a6159
Gerrit-Change-Number: 41712
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 May 2020 09:34:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment