Attention is currently required from: Damien Zammit. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63520 )
Change subject: mb/hp/t620: Add new board HP T620 ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63520/comment/43e24e93_43c1cbd8 PS1, Line 7: mb/hp/t620: Add new board HP T620 Maybe:
Add new AMD Family 16h board
https://review.coreboot.org/c/coreboot/+/63520/comment/dea821f2_df9cbc03 PS1, Line 18: Please summarize the changes: ASpeed Super I/O, …
https://review.coreboot.org/c/coreboot/+/63520/comment/70062e6e_db2bfeab PS1, Line 29: on a running system. There should be a version string in there.
Patchset:
PS1: Seeing all the similarities, maybe it should be a variant, or at least a chipset devicetree could be created?
File src/mainboard/hp/t620/Kconfig:
https://review.coreboot.org/c/coreboot/+/63520/comment/3bcde395_ddbbf587 PS1, Line 1: # SPDX-License-Identifier: GPL-2.0-only Please keep the differences as small as possible.