Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45677 )
Change subject: soc/intel: Use ASL 2.0 syntax for GPIO ASL helper function
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45677/2/src/soc/intel/skylake/acpi/...
File src/soc/intel/skylake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/45677/2/src/soc/intel/skylake/acpi/...
PS2, Line 138: And (GPIOTXSTATE_MASK, ShiftRight (VAL0, PAD_CFG0_TX_STATE_BIT), Local0)
sorry, I don't understand how you got "Local0 = GPIOTXSTATE_MASK & VAL0" […]
#define PAD_CFG0_TX_STATE_BIT 0 hence ignored
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ebf1f86031eae25337d2dbeabb8893d9f19a14b
Gerrit-Change-Number: 45677
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Thu, 24 Sep 2020 14:39:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment