Attention is currently required from: Michał Żygowski. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59517 )
Change subject: security/intel/txt: Use common txt_reset_platform ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
PS3: This change does two things:
- Where applicable, it uses the `set_global_reset()` function that CB:50362 moved to common code. - Replaces a `full_reset()` with `txt_reset_platform()` in the TXT wake error path.
I'd much prefer to have two separate commits.
File src/security/intel/txt/getsec.c:
https://review.coreboot.org/c/coreboot/+/59517/comment/261eda97_f424522f PS3, Line 71: txt_reset_platform(); No, a global reset is not necessary here. This is just to unlock the IA32_FEATURE_CONTROL MSR.
File src/security/intel/txt/romstage.c:
https://review.coreboot.org/c/coreboot/+/59517/comment/a8fcbc02_e082dc71 PS3, Line 112: txt_reset_platform(); OK; Haswell RC does a global reset here.