Attention is currently required from: Henry Sun, Paul2 Huang.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59856 )
Change subject: mb/google/octopus: add audio codec into SSFC support for ApelE
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
On the other hand, please split overridetree.cb to another CL since this one is common for baseboard level.
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59856/comment/78afe6bc_f64cdc8f
PS5, Line 212: if ((audio_dev->chip_ops == &drivers_i2c_generic_ops) &&
Could we category it with line 195 together since they all need to be drivers_i2c_generic_ops?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80be12d88e100ce8586371fc49b36447859e24f8
Gerrit-Change-Number: 59856
Gerrit-PatchSet: 5
Gerrit-Owner: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 Dec 2021 10:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment