[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Felix Held, Hannah Williams, Jamie Ryu.

Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )

Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................

Patch Set 24:

(4 comments)

File src/soc/intel/common/block/include/intelblocks/pmclib.h:

https://review.coreboot.org/c/coreboot/+/84104/comment/db39a42a_9bfe4043?usp... :
PS24, Line 254: return
```/* nop */```

https://review.coreboot.org/c/coreboot/+/84104/comment/636bcf83_f79529e8?usp... :
PS24, Line 259: return
```/* nop */```

File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/84104/comment/dc4386a2_361abbb3?usp... :
PS24, Line 421: 	print_std_gpe1_sts(gpe1_sts);
shouldn't we print first and then reset ?

https://review.coreboot.org/c/coreboot/+/84104/comment/1126c601_08d9d68f?usp... :
PS24, Line 522: 	
one tab less?