Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee...
PS2, Line 348: CTXS(GPP_F15)
We'll need
```
#if CONFIG(BOARD_GOOGLE_VOLTEER)
CTXS(GPP_F15)
#else
CTXS(GPP_D4)
#endif
```
or similar here as well. Although these should probably be in some variant-specific gpio.h file.... but that's for another change.
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee...
PS2, Line 370: CTXS(GPP_F15)
We'll need
```
#if CONFIG(BOARD_GOOGLE_VOLTEER)
CTXS(GPP_F15)
#else
CTXS(GPP_D4)
#endif
```
or similar here as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968
Gerrit-Change-Number: 45159
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bingbu Cao
bingbu.cao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 23:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment