Attention is currently required from: Chris Wang, chris wang.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52736 )
Change subject: mb/google/guybrush: update the telemetry setting
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52736/comment/59d8dd85_3c68432e
PS4, Line 45: #mA
since the register name now includes the _mA postfix, the comment could be dropped. same two lines below. doesn't really hurt to have the comment here though; it's just redundant
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib92bb169693634665fc8e165837e7ae3e6137bcf
Gerrit-Change-Number: 52736
Gerrit-PatchSet: 4
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:31:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment