Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46556 )
Change subject: sec/intel/txt: Update TXT HEAP and SINIT size
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46556/12/src/security/intel/txt/ram...
File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/46556/12/src/security/intel/txt/ram...
PS12, Line 306: define HEAP_SIZE (1 * MiB)
: /* Recent SINIT ACM (COOPERLAKE_SP) are 256KiB but also need 64KiB data size */
: #define SINIT_SIZE ((256 + 64) * KiB)
Is this something that we should handle on the SoC level? […]
I'd make Kconfig symbols to handle this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46556
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e81d051a03b54233eef6ccdc4740c1a709be40
Gerrit-Change-Number: 46556
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 10:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Gerrit-MessageType: comment