Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34145 )
Change subject: src/cpu/intel: Add sanity check for cpu turbo mode capability ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34145/8/src/cpu/intel/turbo/turbo.c File src/cpu/intel/turbo/turbo.c:
https://review.coreboot.org/c/coreboot/+/34145/8/src/cpu/intel/turbo/turbo.c... PS8, Line 55: void This can just return the new turbo_state.
https://review.coreboot.org/c/coreboot/+/34145/8/src/cpu/intel/turbo/turbo.c... PS8, Line 94: update_turbo_state ... then this can be: turbo_state = update_turbo_state();
https://review.coreboot.org/c/coreboot/+/34145/8/src/cpu/intel/turbo/turbo.c... PS8, Line 96: turbo_state Else, this will return stale turbo_state when it is TURBO_UNKNOWN.
https://review.coreboot.org/c/coreboot/+/34145/8/src/include/cpu/intel/turbo... File src/include/cpu/intel/turbo.h:
https://review.coreboot.org/c/coreboot/+/34145/8/src/include/cpu/intel/turbo... PS8, Line 44: /* Update turbo state */ : void update_turbo_state(void); Do we need to expose this? Currently, there are no users. I think its better to just keep it static.