5 Apr
2021
5 Apr
'21
3:16 a.m.
Attention is currently required from: Wenbin Mei. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51966 )
Change subject: soc/mediatek: add new driver 'msdc' for eMMC ......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/51966/comment/c2021df2_fbf14b33 PS5, Line 45: return MSDC_SUCCESS;
I'd suggest using the timer API (timer.h): […]
Also see the wait_us() macro.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 5
Gerrit-Owner: Wenbin Mei wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Wenbin Mei wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Apr 2021 03:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment