Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46398 )
Change subject: soc/mediatek/mt8192: Add multi freq calibration ......................................................................
Patch Set 30:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46398/30/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_main.c:
PS30: Yidi, about the file permission, please run `make gitconfig` in coreboot/, so that pre-commit hook will be installed in coreboot/.git/hooks/ (see [1]). Then, `git commit` will fail if files have wrong permission set. This will also save a great amount of time in the code review process.
Please forward this message to the rest of the team, especially to the people actually doing `git commit`.
[1] https://doc.coreboot.org/tutorial/part2.html#step-3-clone-coreboot-and-confi...