Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Jérémy Compostella, Paul Menzel, Subrata Banik.
Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84210?usp=email )
Change subject: intel/cmm/block: use CONFIG_SMM_TSEG_SIZE in sa_get_tseg_size function
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84210/comment/47b7b21c_bf06b1b1?usp... :
PS2, Line 7: src/
remove `src/`
Done
https://review.coreboot.org/c/coreboot/+/84210/comment/8726788b_af7ed5a5?usp... :
PS2, Line 7: Update sa_get_tseg_size function
Please be more specific.
Done
https://review.coreboot.org/c/coreboot/+/84210/comment/5deeb6c1_3607115f?usp... :
PS2, Line 10: api
API
Done
https://review.coreboot.org/c/coreboot/+/84210/comment/46ebf1b5_53073bdd?usp... :
PS2, Line 10: nagative
negative
Done
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/84210/comment/008e022d_a14fc1b6?usp... :
PS2, Line 155: return sa_get_gsm_base() - sa_get_tseg_base();
WDYT? I assume in absence of IGD the GSM size would be zero hence, we won't get into `if` case. […]
We checked internally and got recommendation not to calculate it as CONFIG_SMM_TSEG_SIZE is passed to FSP and memory map which based on calculation can be changed later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84210?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3d5175add1f7dc6e2c9f1c38133b36ffc59e789
Gerrit-Change-Number: 84210
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 10 Sep 2024 00:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org