Attention is currently required from: Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 )
Change subject: cpu/intel/sandybridge: Add `hyper_threading` option
......................................................................
Patch Set 18:
(1 comment)
File src/cpu/intel/model_206ax/bootblock.c:
https://review.coreboot.org/c/coreboot/+/29669/comment/2035e550_f989082f
PS18, Line 87: if (need_reset) {
How about inverting the condition so that the trivial case comes first? This way we also save the indentations.
```
if (!need_reset) {
RCBA32_OR(SOFT_RESET_LOCK, 1);
return;
}
/* Set current requests */
RCBA32(SOFT_RESET_DATA) = soft_reset;
....
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b73e32ff5af8ea64a47e8aa706e27648aaf0993
Gerrit-Change-Number: 29669
Gerrit-PatchSet: 18
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 08 Apr 2023 20:11:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment