Attention is currently required from: Shelley Chen, Taniya Das, Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Make clock_configure() check for exact matches ......................................................................
Patch Set 8:
(3 comments)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/e1a1ee0d_fa6fe214 PS8, Line 103: if (hz != clk_cfg[idx].hz) Wait! Wait wait wait... sorry, should have seen this earlier. idx is out of bounds here in the error case, that's not good. Need to check (idx >= num_perfs) instead.
Also need to make sure that also those mdss functions which pass num_perfs=0 right now actually pass 1 then.
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/9f515ad5_943c6fdd PS7, Line 412: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz; Indentation?
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/c792288d_2d5055de PS8, Line 418: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz; Well, now you're again risking that `mdss_clk_cfg.hz` and `hz` don't match, though. You can't do this, or you need to update `hz` too.