Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56236 )
Change subject: soc/amd/picasso,stoneyridge/mca: mark num_banks as constant ......................................................................
soc/amd/picasso,stoneyridge/mca: mark num_banks as constant
Change-Id: I23aa4d36d4e6d4c7ed66800c2e7963c4ed03c393 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/mca.c M src/soc/amd/stoneyridge/mca.c 2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/56236/1
diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c index 65b1916..3c5dd10 100644 --- a/src/soc/amd/picasso/mca.c +++ b/src/soc/amd/picasso/mca.c @@ -154,9 +154,7 @@ { int i; struct mca_bank mci; - unsigned int num_banks; - - num_banks = mca_get_bank_count(); + const unsigned int num_banks = mca_get_bank_count();
for (i = 0 ; i < num_banks ; i++) { mci.sts = rdmsr(MCAX_STATUS_MSR(i)); diff --git a/src/soc/amd/stoneyridge/mca.c b/src/soc/amd/stoneyridge/mca.c index c2ec402..6432ff4 100644 --- a/src/soc/amd/stoneyridge/mca.c +++ b/src/soc/amd/stoneyridge/mca.c @@ -153,9 +153,7 @@ { int i; struct mca_bank mci; - unsigned int num_banks; - - num_banks = mca_get_bank_count(); + const unsigned int num_banks = mca_get_bank_count();
if (is_warm_reset()) { for (i = 0 ; i < num_banks ; i++) {