Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44627 )
Change subject: soc/intel/tigerlake: Fix IPU and Vtd config
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44627/3/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44627/3/src/soc/intel/tigerlake/rom...
PS3, Line 176: if (m_cfg->InternalGfx) {
: m_cfg->VtdIgdEnable = 0x1;
: m_cfg->VtdBaseAddress[0] = GFXVT_BASE_ADDRESS;
: }
:
: if (m_cfg->SaIpuEnable) {
: m_cfg->VtdIpuEnable = 0x1;
: m_cfg->VtdBaseAddress[1] = IPUVT_BASE_ADDRESS;
: }
This is minor but can we move this code up after line 172?
Then we have sequential code for VtdBaseAddress array.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieff57fb0ebc8522546d6b34da6ca2f2f845bf61d
Gerrit-Change-Number: 44627
Gerrit-PatchSet: 3
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Wed, 19 Aug 2020 23:52:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment