Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36029 )
Change subject: drivers/i2c/rt1011: Add a driver for RT1011
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
Thank you for the detailed explanation. I guess, ACPI is reality, but I still think, the OS driver should read it directly.
https://review.coreboot.org/c/coreboot/+/36029/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36029/9//COMMIT_MSG@11
PS9, Line 11: Management(DSM)
Please add a space before the (.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9550b9890ce2cae787f4f17779a5ade77f619171
Gerrit-Change-Number: 36029
Gerrit-PatchSet: 9
Gerrit-Owner: Cheng-Yi Chiang
cychiang@chromium.org
Gerrit-Reviewer: Cheng-Yi Chiang
cychiang@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jimmy Cheng-Yi Chiang
cychiang@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Oct 2019 17:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment