Attention is currently required from: Raul Rangel, Kangheui Won, Julius Werner, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68953 )
Change subject: security/vboot: Update build rules using x86 SHA extension
......................................................................
Patch Set 2:
(2 comments)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68953/comment/d9d0129b_4e5c5339
PS1, Line 26: ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
I don't know much about Kconfig so not sure if we can select different options for different stage […]
Done. As Kangheui mentioned, the preference is to use x86 SHA extension for all the stages that use vboot verification except verstage which runs in ARM PSP.
https://review.coreboot.org/c/coreboot/+/68953/comment/5e55405f_a4e659c5
PS1, Line 27: 0
Make it empty to be consistent with `$(CONFIG_VBOOT_X86_SHA256_ACCELERATION)`?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f388e963eb82990cda41d3880e66ad937334908
Gerrit-Change-Number: 68953
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 31 Oct 2022 22:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment