Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83245?usp=email )
Change subject: tgl mainboards: Move usb{2,3}_ports settings into XHCI device scope
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
this breaks many USB ports for google/volteer as the baseboard port definitions are no longer inherited by the variant. Fix in CB:84348
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83245?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide5126c6e642ca16249efeaf46321724f2ddce9a
Gerrit-Change-Number: 83245
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 21:09:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No