9 Feb
2021
9 Feb
'21
1:55 a.m.
Attention is currently required from: Furquan Shaikh, Julius Werner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41122 )
Change subject: cbfstool: Add support for platform "fixups" when modifying bootblock ......................................................................
Patch Set 21: Code-Review+1
(2 comments)
File util/cbfstool/platform_fixups.c:
https://review.coreboot.org/c/coreboot/+/41122/comment/d2a7d58d_46449d3b PS21, Line 17: 32KB nit: KiB?
https://review.coreboot.org/c/coreboot/+/41122/comment/12ea15a6_9e569697 PS21, Line 47: (int) What is the purpose of this cast to int?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02a83a40f1d0009e6f9561ae5d2d9f37a510549a
Gerrit-Change-Number: 41122
Gerrit-PatchSet: 21
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 09 Feb 2021 09:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment