Hello Nicolas Boichat,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46580
to review the following change.
Change subject: HACK: skip reading EDID completely ......................................................................
HACK: skip reading EDID completely
Something goes terribly wrong when reading the EDID, and ANX7625 does not seem to be able to recover from it.
BUG=b:155713214 TEST=boot asurada
Change-Id: I2230af30b709667f9858f6144b14681686003f28 --- M src/drivers/analogix/anx7625/anx7625.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/46580/1
diff --git a/src/drivers/analogix/anx7625/anx7625.c b/src/drivers/analogix/anx7625/anx7625.c index eb7e661..e3f969c 100644 --- a/src/drivers/analogix/anx7625/anx7625.c +++ b/src/drivers/analogix/anx7625/anx7625.c @@ -854,7 +854,9 @@ int ret; u8 edid[FOUR_BLOCK_SIZE];
- block_num = sp_tx_edid_read(bus, edid, FOUR_BLOCK_SIZE); + /* Something goes terribly wrong here, and ANX7625 does not seem to be able to recover from it. */ + if (0) + block_num = sp_tx_edid_read(bus, edid, FOUR_BLOCK_SIZE); block_num=1;
memcpy(edid, &edp_edid, sizeof(edp_edid));