Attention is currently required from: Nicholas Chin, Nico Huber, Paul Menzel, Riku Viitanen.
Felix Singer has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79745?usp=email )
Change subject: mb/hp: Add Compaq Elite 8300 CMT port ......................................................................
Patch Set 17:
(14 comments)
File src/mainboard/hp/compaq_elite_8300_cmt/Kconfig:
https://review.coreboot.org/c/coreboot/+/79745/comment/58cf3a7b_26760e71?usp... : PS17, Line 1: if ```suggestion ## SPDX-License-Identifier: GPL-2.0-only
if BOARD_HP_COMPAQ_ELITE_8300_CMT ```
File src/mainboard/hp/compaq_elite_8300_cmt/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/79745/comment/ff6d125a_589627b7?usp... : PS17, Line 1: co ```suggestion ## SPDX-License-Identifier: GPL-2.0-only
config BOARD_HP_COMPAQ_ELITE_8300_CMT ```
File src/mainboard/hp/compaq_elite_8300_cmt/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/79745/comment/c336e625_13ff6e02?usp... : PS17, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ ```suggestion /* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */ ```
File src/mainboard/hp/compaq_elite_8300_cmt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79745/comment/62896250_a44261cf?usp... : PS17, Line 4: register "gfx.use_spread_spectrum_clock" = "0" : register "gpu_dp_b_hotplug" = "0" : register "gpu_dp_c_hotplug" = "0" : r Remove, since initialized with 0.
https://review.coreboot.org/c/coreboot/+/79745/comment/d849bee3_fd6db63f?usp... : PS17, Line 13: device ref host_bridge on end # Host bridge Host bridge : device ref peg10 on end # PEG : device ref igd on end # iGPU Please remove superfluous comments duplicating the device names. More are below.
```suggestion device ref host_bridge on end device ref peg10 on end device ref igd on end ```
https://review.coreboot.org/c/coreboot/+/79745/comment/1a61dbc5_7d536a4c?usp... : PS17, Line 18: register "docking_supported" = "0" : Remove, initialized with 0.
```suggestion register "gen1_dec" = "0x00fc0a01" ```
https://review.coreboot.org/c/coreboot/+/79745/comment/54599cec_660e3dc3?usp... : PS17, Line 21: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" : Remove, initialized with 0.
```suggestion register "pcie_port_coalesce" = "1" ```
https://review.coreboot.org/c/coreboot/+/79745/comment/20b39223_e4364a85?usp... : PS17, Line 48: device ref mei1 off end # Management Engine Interface 1 Any specific reason for disabling the MEI device?
https://review.coreboot.org/c/coreboot/+/79745/comment/bb203936_ed23f094?usp... : PS17, Line 49: device ref mei2 off end : device ref me_ide_r off end : device ref me_kt off end : Remove, disabled by default.
```suggestion device ref gbe on end # Intel Gigabit Ethernet ```
File src/mainboard/hp/compaq_elite_8300_cmt/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/79745/comment/aac74b96_df4b1422?usp... : PS17, Line 11: 0x20141018 /* OEM revision */ ```suggestion 0x20141018 ```
File src/mainboard/hp/compaq_elite_8300_cmt/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/79745/comment/d474657c_bf47053b?usp... : PS17, Line 10: AZALIA_PIN_CFG(0, 0x12, 0x411111f0), ```suggestion AZALIA_PIN_CFG(0, 0x12, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/79745/comment/a70c2dc6_47400059?usp... : PS17, Line 13: AZALIA_PIN_CFG(0, 0x18, 0x411111f0), : A ```suggestion AZALIA_PIN_CFG(0, 0x18, AZALIA_PIN_CFG_NC(0)), AZALIA_PIN_CFG(0, 0x19, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/79745/comment/f813678a_49e1cd27?usp... : PS17, Line 18: AZALIA_PIN_CFG(0, 0x1e, 0x411111f0), ```suggestion AZALIA_PIN_CFG(0, 0x1e, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/79745/comment/66ae67e2_0fbbb129?usp... : PS17, Line 27: AZALIA_PIN_CFG(3, 0x07, 0x58560030), : : }; Remove blank line
```suggestion AZALIA_PIN_CFG(3, 0x07, 0x58560030), }; ```