Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34804 )
Change subject: arch/x86: Flip option NO_CAR_GLOBAL_MIGRATION
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34804/3/src/cpu/Kconfig
File src/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/34804/3/src/cpu/Kconfig@16
PS3, Line 16: default y if !RELOCATABLE_RAMSTAGE
This looks already incredibly odd. There is no direct relation of […]
Well first, there is 'default n' followed by 'default y if xxx' which was already wrong.
Indeed I should not need the ref to RELOCATABLE_RAMSTAGE here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dbad6a14e68bf566ac0f151dc8ea259e5ae2250
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 09 Aug 2019 11:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment