Attention is currently required from: Tristan Corrick, Angel Pons, Arthur Heymans, Alexander Couzens, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51440 )
Change subject: nb/intel/haswell: Decouple mainboard USB config from MRC
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/northbridge/intel/haswell/raminit.h:
https://review.coreboot.org/c/coreboot/+/51440/comment/8ab7d829_d3c35d72
PS7, Line 37: uint16_t
Not sure if it's useful to use a fixed-width here (and for `oc_pin`).
File src/northbridge/intel/haswell/raminit.c:
https://review.coreboot.org/c/coreboot/+/51440/comment/aa74134a_2d6b3046
PS7, Line 362: USB_OC_PIN_SKIP
PEI_?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51440
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc405213e9b0828d9ced18677335533c7dd381d
Gerrit-Change-Number: 51440
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 13 Mar 2021 13:19:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
