[coreboot-gerrit] [M] Change in coreboot[master]: drivers/ocp: add VPD processing framework

[Jonathan Zhang (Code Review)]

Attention is currently required from: Marc Jones, Johnny Lin, Paul Menzel, Johnny Li, Arthur Heymans, Shuming Chu (Shuming), Angel Pons, Tim Chu.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68784 )

Change subject: drivers/ocp: add VPD processing framework
......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2: 
Johnny, please check out this thread.

File src/drivers/ocp/vpd/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/68784/comment/ef1b035e_f7f0d8bf 
PS2, Line 3: smm-$(C
> It's not a good idea to fetch VPD in the smihandler. Do you really need this? […]

We do need to customize SMI handler behavior based on firmware configuration (in this case, VPD), to configure things such as the SMI handler log level.

We think that we need to fetch VPD at least once in the smihandler. Another option is to fetch it in the ramstage and save it somewhere for smi handlers to pick up. @Johnny, could you comment on this?

CONFIG_VPD_SMM_SUPPORT is defined in our SPR production codebase, and we could use it for DeltaLake as well.

For this patch itself, let me remove this statement, while we continue the discussion on CONFIG_VPD_SMM_SUPPORT.