Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )
Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lindar/gpio.c:
https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee...
PS4, Line 137: /* E15 : ISH_GP6 ==> NC */
: PAD_NC(GPP_E15, NONE),
:
May i know the reason behind of setting this?
Because TRACKPAD_INT_ODL pin no response on Synaptics trackpad device after power on. And it can be fixed after config GPP_E15 to early GPIO table.
https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee...
PS4, Line 39: .rise_time_ns = 0,
: .fall_time_ns = 0,
: .data_hold_time_ns = 0,
Is this needed? I think the default value should be zero, isn't it?
You`re right, i remove useless code change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
Gerrit-Change-Number: 48150
Gerrit-PatchSet: 5
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 03 Dec 2020 06:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment