Attention is currently required from: Lance Zhao, Anil Kumar K, Subrata Banik, Paul Menzel, Thejaswani Putta, Patrick Rudolph. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61352 )
Change subject: soc/intel/common/block/pcie/rtd3: Add PM methods to the device. ......................................................................
Patch Set 6:
(5 comments)
File src/soc/intel/common/block/pcie/rtd3/chip.h:
https://review.coreboot.org/c/coreboot/+/61352/comment/21ff9e48_6b4edabd PS5, Line 9: ACPI_PCIE_RP_EMIT_NONE = 0x00, /* None */ : ACPI_PCIE_RP_EMIT_L23 = 0x01, /* L23 */ : ACPI_PCIE_RP_EMIT_PSD0 = 0x02, /* PSD0 */ : ACPI_PCIE_RP_EMIT_SRCK = 0x04, /* SRCK */ : ACPI_PCIE_RP_EMIT_L23_PSD0 = 0x03, /* L23, PSD0 */ : ACPI_PCIE_RP_EMIT_L23_SRCK = 0x05, /* L23, SRCK */ : ACPI_PCIE_RP_EMIT_PSD0_SRCK = 0x06, /* PSD0, SRCK */ : ACPI_PCIE_RP_EMIT_ALL = 0x07 /* L23, PSD0, SRCK */ : };
You know what, I was thinking too far ahead, I was thinking of refactoring this too, so that the int […]
okay. Let's have separate one for refactoring and we can also change to use acpigen_[method/if/scope/device]_end() instead of acpigen_pop_len(), as well as using extra C brackets (i.e. { and }) and indention to match closer to the generated ACPI code in there. Those two good ideas from you.
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/61352/comment/63ab8f86_f56a3530 PS6, Line 104: static void : pcie_rtd3_acpi_method_dl23(void)
nit: fits on one line
Done
https://review.coreboot.org/c/coreboot/+/61352/comment/d0caacc0_a9e61d5f PS6, Line 113: static void : pcie_rtd3_acpi_method_l23d(void)
nit: fits on one line
Done
https://review.coreboot.org/c/coreboot/+/61352/comment/a394da43_6072aca3 PS6, Line 122: static void : pcie_rtd3_acpi_method_pds0(unsigned int pcie_rp)
nit: fits on one line
Done
https://review.coreboot.org/c/coreboot/+/61352/comment/bf9818db_b2aa6752 PS6, Line 131: static void : pcie_rtd3_acpi_method_srck(unsigned int pcie_rp, : const struct soc_intel_common_block_pcie_rtd3_config *config)
nit: […]
Done