Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47311 )
Change subject: mb/google/zork: Power off fingerprint sensor on shutdown ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... PS3, Line 354: if (slp_typ == SLP_TYP_S5) {
The fingerprint team has said that this shutdown is desired, although not required. […]
Quick question: Is there external PD on the GPIO_11 signal? If yes, then you don't need this setting at all. All GPIOs are reset on any kind of SoC reset. It guarantees that the pad state is set to default. So, as long as there is an external strong PD on the EN_PWR_FP pin, this configuration is not really required.