Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Shon Wang has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83593?usp=email )
Change subject: mb/google/brask/var/bujia: Add PsysPmax setting ......................................................................
Patch Set 9:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83593/comment/938f8ad1_39fae794?usp... : PS8, Line 9: displayer
display
Done
File src/mainboard/google/brya/variants/bujia/include/variant/get_input_power_voltage.h:
https://review.coreboot.org/c/coreboot/+/83593/comment/9f2d3a45_0a3bca56?usp... : PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ : : #ifndef VARIANT_GET_INPUT_POWER_VOLTAGE_H : #define VARIANT_GET_INPUT_POWER_VOLTAGE_H : : int32_t get_input_power_voltage(void); : : #endif :
This file is redundant.
Done
File src/mainboard/google/brya/variants/bujia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83593/comment/54c65515_8051f986?usp... : PS8, Line 10: #include <fw_config.h>
redundant
Done
https://review.coreboot.org/c/coreboot/+/83593/comment/d5acbb5e_7d67c95f?usp... : PS8, Line 12: #include <variant/get_input_power_voltage.h>
redundant
Done
https://review.coreboot.org/c/coreboot/+/83593/comment/c064b2c4_25292c0f?usp... : PS8, Line 41: kuldax
bujia
Done
https://review.coreboot.org/c/coreboot/+/83593/comment/4b1d9cac_b95ac6bd?usp... : PS8, Line 64: int32_t
static int32_t
Done