[coreboot-gerrit] [L] Change in coreboot[main]: mb/google/fatcat: Add GPIO settings

[Cliff Huang (Code Review)]

Attention is currently required from: Jérémy Compostella, Pranava Y N, Subrata Banik, Wonkyu Kim.

Cliff Huang has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84405?usp=email )

Change subject: mb/google/fatcat: Add GPIO settings
......................................................................

Patch Set 22:

(5 comments)

File src/mainboard/google/fatcat/variants/fatcat/gpio.c:

https://review.coreboot.org/c/coreboot/+/84405/comment/21ab9d7e_1ed1d229?usp... :
PS1, Line 437: 	/* GPP_B16:     GEN5_SSD_PWREN */
             : 	PAD_CFG_GPO(GPP_B16, 0, PLTRST),
> > will move to romstage and use fw_config. […]

done in https://review.coreboot.org/c/coreboot/+/84408/19

https://review.coreboot.org/c/coreboot/+/84405/comment/8a64074a_9872bde5?usp... :
PS1, Line 440: 	/* GPP_C05:     CRD1_PWREN */
> > This is used for world facing camera. […]

We will need fw_config for camera1 & 2. I created tables are ready in https://review.coreboot.org/c/coreboot/+/84408/19.

https://review.coreboot.org/c/coreboot/+/84405/comment/cc14f2c8_26f78b95?usp... :
PS1, Line 452: 	/* M.2 WWAN */
> same, this should be inside FW config.

Done

https://review.coreboot.org/c/coreboot/+/84405/comment/f9929371_7d9f82df?usp... :
PS1, Line 459: 
             : 	/* GPP_D03:     M.2_WWAN_PERST_GPIO_N */
> same

Done

File src/mainboard/google/fatcat/variants/fatcat/gpio.c:

https://review.coreboot.org/c/coreboot/+/84405/comment/f2f8e69f_288cd211?usp... :
PS21, Line 412: 	/* GPP_C00:     GPP_C0_SMBCLK */
              : 	PAD_CFG_NF(GPP_C00, NONE, DEEP, NF1),
              : 	/* GPP_C01:     GPP_C1_SMBDATA */
              : 	PAD_CFG_NF(GPP_C01, NONE, DEEP, NF1),
              :
> this SPD SMB. should be okay to move to romstage. Let me build & test.

Done