[coreboot-gerrit] [S] Change in coreboot[master]: [RFC] soc/intel/skylake: Use boolean type for s0ix_enable devicetree ...

[Felix Singer (Code Review)]

Attention is currently required from: Arthur Heymans, Elyes Haouas, Eric Lai, Jan Samek, Mario Scheithauer, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Subrata Banik.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75871?usp=email )

Change subject: [RFC] soc/intel/skylake: Use boolean type for s0ix_enable devicetree option
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS3:
> Suggestion: replace true/false by enabled/disabled everywhere in coreboot code where it sounds more  […]

So I think we all like the idea and we just have some differences in the details, but I think it's not too much a problem.

I will make this one ready tomorrow and I will start pushing more patches then. I won't change the variable names, just change the values and types. Changing names is a very different topic IMO.

Please help reviewing these. There will be some.