[coreboot-gerrit] Change in coreboot[master]: soc/nvidia/tegra124: Fix null pointer and logic bug

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35904 )

Change subject: soc/nvidia/tegra124: Fix null pointer and logic bug
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/35904/1/src/soc/nvidia/tegra124/spi... 
File src/soc/nvidia/tegra124/spi.c:

https://review.coreboot.org/c/coreboot/+/35904/1/src/soc/nvidia/tegra124/spi... 
PS1, Line 564: 		while ((read32(&spi->dma_out->regs->dma_byte_sta) < todo) ||
> This is the fix for the logic bug, which was copied from the previous commit.

The call to spi_delay() below makes this a bit different logic bug. But I guess this is the best we can do without someone actually triggering the bug first to document the symptoms.