Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )
Change subject: src: Add '-Wduplicated-branches' warning option ......................................................................
Patch Set 23:
Such warning options can produce a lot of noise, e.g. false positives. Unless there was a serious bug in the past that would have been discovered by this, I'd prefer _not_ to use this option.
The nvidia/tegra124 code (https://review.coreboot.org/c/coreboot/+/40430) looks like a real bug.
Thanks, that's a real bug indeed. I wonder if there is no simpler warning option for no-op statements (the branches are the same in this case because both do nothing).
If the non-vendorcode code would build with that option, I believe it’s a good thing, as developers can often reorganize the code (helping other developers to understand it better).
The problem is to get it to build without making it harder to read.