Attention is currently required from: Lance Zhao, Subrata Banik, Caveh Jalali, Tim Wawrzynczak, Sumeet R Pawnikar, Maximilian Brune, Boris Mittelberg.
Hello Lance Zhao, build bot (Jenkins), Subrata Banik, Caveh Jalali, Reka Norman, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Lean Sheng Tan, Boris Mittelberg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73249
to look at the new patch set (#5).
Change subject: Reland "drivers/intel/dptf: Add multiple fan support under dptf" ......................................................................
Reland "drivers/intel/dptf: Add multiple fan support under dptf"
This reverts commit 4dba71fd25c91a9e610287c61238a8fe24452e4e.
Add multiple fan support for dptf policies.
This also fixes the Google Meet resolution drop issue as per b:246535768 comment#12. When system starts Google Meet video call, it uses the hardware accelerated encoder as expected. But, as soon as another system connects to the call, an immediate fallback is observed from hardware to software encoder. Due to this, Google Meet resolution dropped from 720p to 180p. This issue is observed on Alder Lake-N SoC based fanless platforms. This same issue was not seen on fan based systems. With the fix in dptf driver where fan configures appropriate setting for only fan participant, not for other device participants, able to see consistent 720p resolution.
BUG=b:246535768,b:235254828 BRANCH=None TEST=Built and tested on Alder Lake-P Redrix system for two fans support and on Alder Lake-N fanless systems. With this code change Google Meet resolution drop not observed.
Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Change-Id: Id07d279ff962253c22be9d395ed7be0d732aeaa7 --- M src/acpi/acpigen_dptf.c M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/ec/google/chromeec/acpi/emem.asl M src/ec/google/chromeec/chip.h M src/ec/google/chromeec/ec_acpi.c M src/ec/google/chromeec/ec_dptf_helpers.c M src/ec/google/common/dptf.h M src/include/acpi/acpigen_dptf.h 9 files changed, 240 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/73249/5