Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35080 )
Change subject: Documentation/acpi: Add new document on adding ACPI devices to devicetree ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35080/6/Documentation/acpi/devicetr... File Documentation/acpi/devicetree.md:
https://review.coreboot.org/c/coreboot/+/35080/6/Documentation/acpi/devicetr... PS6, Line 119: e. This property is used to match the device to its driver during enumeration in the OS.
https://review.coreboot.org/c/coreboot/+/35080/6/Documentation/acpi/devicetr... PS6, Line 141: informs the platform that the GPIO : will be routed through SCI (ACPI's System Control Interrupt) Also, that this is the Interrupt() resource that will be added to _CRS to provide information about the device interrupt to its driver. Here it is marked as active low and triggered on edge i.e. falling edge.
https://review.coreboot.org/c/coreboot/+/35080/6/Documentation/acpi/devicetr... PS6, Line 143: . This requires that the gpio GPP_A21 be configured in coreboot accordingly.
https://review.coreboot.org/c/coreboot/+/35080/6/Documentation/acpi/devicetr... PS6, Line 157: . It might be helpful to indicate #21 is actually GPP_X21 where GPP_X is mapped to DW0 in devicetree.cb
https://review.coreboot.org/c/coreboot/+/35080/6/Documentation/acpi/devicetr... PS6, Line 183: There are no : dependent power resources Are you planning on adding information about power resources later?