David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29862 )
Change subject: soc/{amd,intel}: Remove duplicated '&' on ptr's function ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
You can include denverton_ns/systemagent.c if you wish. But I think the ops structures need the &
https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemage... File src/soc/intel/denverton_ns/systemagent.c:
https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemage... PS1, Line 342: .ops_pci = &soc_pci_ops, soc_pci_ops is a structure not a function, it requires the &
https://review.coreboot.org/#/c/29862/1/src/soc/intel/denverton_ns/systemage... PS1, Line 353: .ops = &systemagent_ops, Here too, systemagent_ops is a structure not a function, requires the &