Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33844 )
Change subject: src/security/vboot: Add option to skip display init with vboot 2.0
......................................................................
Patch Set 7:
Beside breaking non-chromeos boards (CB:34308) what is the effect
of this? I have to ask because the commit message says roughly
the opposite of what the patch does:
* Patch *limits* display-init skipping in `bootmode.c`.
* Commit message talks about adding it.
So:
* Why is the Kconfig option added?
* Why does it have a prompt?
* Why have vendor specific defaults in vboot/?
* How does this relate to ALWAYS_RUN_OPROM? is that obsolete?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icadad6da34dcb817af02868e89a94ea62dbfa7b3
Gerrit-Change-Number: 33844
Gerrit-PatchSet: 7
Gerrit-Owner: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Sachin Agrawal
sachin.agrawal@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Mon, 29 Jul 2019 10:23:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment