2 Mar
2019
2 Mar
'19
6:55 a.m.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31682/3/src/include/device/pci_ids.h File src/include/device/pci_ids.h:
https://review.coreboot.org/#/c/31682/3/src/include/device/pci_ids.h@2094 PS3, Line 2094: #define PCI_DEVICE_ID_INTEL_ISHB 0x9dfc 0x9dfc only for ISH for cannonlake pch, change to PCI_DEVICE_ID_INTEL_CNL_ISHB instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8be986185282521aee574027503eaf8968e1508
Gerrit-Change-Number: 31682
Gerrit-PatchSet: 3
Gerrit-Owner: Jett Rink jettrink@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jett Rink jettrink@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Lijian Zhao lijian.zhao@intel.com
Gerrit-Comment-Date: Fri, 01 Mar 2019 21:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment